feat: migrate avoid_final_with_getter#242
Conversation
refactor: extract GetterVariableVisitor into a file refactor: extract GetterReferenceId into a file test(avoid_final_with_getter): migrate tests
There was a problem hiding this comment.
Code Review
This pull request migrates the avoid_final_with_getter lint rule and its quick fix to the new analysis_server_plugin API, replacing the custom lint implementation with AnalysisRule and ResolvedCorrectionProducer. Feedback on the changes suggests enhancing the quick fix to rename all references to the private variable and getter to avoid compilation errors, and extending getterReferenceId to support explicit this. accesses and block bodies.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
fix: also check getter returning private final fields with this keyword
refactor: extract GetterVariableVisitor into a file
refactor: extract GetterReferenceId into a file
test(avoid_final_with_getter): migrate tests